[Ruckus] Cannot generate release notes

XMLWordPrintable

    • Type: Bug
    • Resolution: resolved
    • Priority: Minor
    • Component/s: None
    • None

      When running make release command with a previous tag in the repository  https://github.com/slaclab/epix-hr-m-320k, an error occurs while generating the release notes. See below

      dnajjar@rdsrv314  (pre-release) $ make release
      
      =============================================================================
      Generating Release
         Project      = ePixHRM320k
         Out Dir      = /afs/slac/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/build/ePixHRM320k
         Version      = 0x01010700
         Build String = ePixHRM320k: Vivado v2023.1, rdsrv314 (Ubuntu 20.04.6 LTS), Built Thu 02 May 2024 09:54:08 AM PDT by dnajjar
         GIT Hash     = 3f7fb39f6483bde8e21619a85d3ec88589d46297
      =============================================================================
      
      
      Available Releases:
          0: ePixHRM320k
      
      Using command line arg release: ePixHRM320k
      
      Finding builds for target ePixHRM320k:
          0: ePixHRM320k-0x01000400-20240323061941-dnajjar-ff123db
          1: ePixHRM320k-0x01000400-20240404034950-dnajjar-5ff52ab
          2: ePixHRM320k-0x01000400-20240404115332-dnajjar-dirty
          3: ePixHRM320k-0x01000400-20240404193604-dnajjar-dirty
          4: ePixHRM320k-0x01010700-20240405013541-dnajjar-f31d001
          5: ePixHRM320k-0x01010700-20240405134019-dnajjar-dirty
          6: ePixHRM320k-0x01010700-20240405153809-dnajjar-1d8394b
          7: ePixHRM320k-0x01010700-20240405175339-dnajjar-3529d55
          8: ePixHRM320k-0x01010700-20240405214136-dnajjar-9399ce2
          9: ePixHRM320k-0x01010700-20240405233002-dnajjar-085b25e
          10: ePixHRM320k-0x01010700-20240406015238-dnajjar-e38c589
          11: ePixHRM320k-0x01010700-20240406075337-dnajjar-57bad7f
          12: ePixHRM320k-0x01010700-20240406092855-dnajjar-d8589bb
          13: ePixHRM320k-0x01010700-20240410131404-dnajjar-f60938e
          14: ePixHRM320k-0x01010700-20240410190624-dnajjar-dirty
          15: ePixHRM320k-0x01010700-20240410233738-dnajjar-dirty
          16: ePixHRM320k-0x01010700-20240411113406-dnajjar-0b9a59f
          17: ePixHRM320k-0x01010700-20240411153239-dnajjar-dirty
          18: ePixHRM320k-0x01010700-20240411164326-dnajjar-dirty
          19: ePixHRM320k-0x01010700-20240411203054-dnajjar-dirty
          20: ePixHRM320k-0x01010700-20240411232145-dnajjar-688dcb4
          21: ePixHRM320k-0x01010700-20240412074657-dnajjar-cabb463
          22: ePixHRM320k-0x01010700-20240412102622-dnajjar-02a1e6b
          23: ePixHRM320k-0x01010700-20240412114244-dnajjar-46845af
          24: ePixHRM320k-0x01010700-20240413170232-dnajjar-46845af
          25: ePixHRM320k-0x01010700-20240413192527-dnajjar-54d24eb
          26: ePixHRM320k-0x01010700-20240416142542-dnajjar-00a20c7
          27: ePixHRM320k-0x01010700-20240417191056-dnajjar-cab4493
          28: ePixHRM320k-0x01010700-20240418042912-dnajjar-72c2c87
          29: ePixHRM320k-0x01010700-20240418092851-dnajjar-dirty
          30: ePixHRM320k-0x01010700-20240418161058-dnajjar-eb91dd2
          31: ePixHRM320k-0x01010700-20240430141018-dnajjar-dirty
          32: ePixHRM320k-0x01010700-20240430172230-dnajjar-2f1b668
      
      Enter index of build to include for target ePixHRM320k: 32
      
      Finding images for target ePixHRM320k, build ePixHRM320k-0x01010700-20240430172230-dnajjar-2f1b668...
          Found: ePixHRM320k-0x01010700-20240430172230-dnajjar-2f1b668.mcs
      
      Enter version for release (i.e. v1.2.3): v1.1.8
      
      Enter previous version for compare (i.e. v1.2.3) or enter for none: v1.1.7
      
      Using version v1.1.8 and previous version v1.1.7
      
      Release = ePixHRM320k
      Version = v1.1.8
      Images  = 
      	/afs/slac/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/targets/ePixHRM320k/images/ePixHRM320k-0x01010700-20240430172230-dnajjar-2f1b668.mcs
      
      Finding Rogue Files...
      
      Creating Rogue zipfile /afs/slac.stanford.edu/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/release/rogue_v1.1.8.zip
      GitDir = /afs/slac/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/..
      
      Logging into github....
      
      Enter your github token. If you do no have one you can generate it here:
          https://github.com/settings/tokens
      You may set it in your environment as GITHUB_TOKEN
      
      Github token: *******************
      
      Creating and pushing tag v1.1.8 .... 
      
      Generating release notes ...
      Traceback (most recent call last):
        File "/afs/slac/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/submodules/ruckus/scripts/firmwareRelease.py", line 697, in <module>
          pushRelease(cfg,relName,relData,ver,tagAttach,prev)
        File "/afs/slac/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/submodules/ruckus/scripts/firmwareRelease.py", line 651, in pushRelease
          md = releaseNotes.getReleaseNotes(git.Git(gitDir), remRepo, oldTag=relOld, newTag=relNew)
        File "/afs/slac.stanford.edu/g/controls/development/users/dnajjar/sandBox/epix-hr-m-320k/firmware/submodules/ruckus/scripts/releaseNotes.py", line 88, in getReleaseNotes
          iList = re.compile(r'(#\d+)').findall(body)
      TypeError: expected string or bytes-like object
      make: *** [../../submodules/ruckus/system_vivado.mk:353: release] Error 1 

              Assignee:
              Unassigned
              Reporter:
              Dawood Alnajjar
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: