Clean up compile warnings

XMLWordPrintable

    • Type: Bug
    • Resolution: resolved
    • Priority: Minor
    • Component/s: None
    • None

      Compiling rogue on a Mac yields several warnings. We should clean these up where we can.

      [ 2%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/data/DataCard.cpp.o
      [ 2%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/data/DataMap.cpp.o
      [ 4%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/data/module.cpp.o
      [ 5%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/EvrStatus.cpp.o
      [ 6%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/EvrControl.cpp.o
      [ 8%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/Info.cpp.o
      [ 9%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/PciStatus.cpp.o
      [ 10%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/PgpCard.cpp.o
      [ 12%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/Status.cpp.o
      [ 13%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/pgp/module.cpp.o
      [ 14%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/rce/AxiStream.cpp.o
      [ 16%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/rce/MapMemory.cpp.o
      [ 17%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/rce/module.cpp.o
      [ 18%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/axi/AxiMemMap.cpp.o
      [ 20%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/axi/AxiStreamDma.cpp.o
      [ 21%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/axi/module.cpp.o
      [ 22%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/hardware/module.cpp.o
      [ 24%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/memory/Hub.cpp.o
      [ 25%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/memory/Master.cpp.o
      [ 26%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/memory/Slave.cpp.o
      [ 28%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/memory/Transaction.cpp.o
      [ 29%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/memory/TransactionLock.cpp.o
      [ 30%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/memory/module.cpp.o
      [ 32%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/Buffer.cpp.o
      [ 33%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/Fifo.cpp.o
      [ 34%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/Frame.cpp.o
      [ 36%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/FrameIterator.cpp.o
      [ 37%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/FrameLock.cpp.o
      [ 38%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/Master.cpp.o
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:103:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:103:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:103:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:111:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:111:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:111:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:130:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:130:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:130:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:138:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:138:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:138:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:211:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:211:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:211:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:234:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:234:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:234:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:242:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ~~~~~~^~~~~~~~~~~~~~
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:242:16: note: place parentheses around the assignment to silence this warning
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ( )
      /Users/bareese/rogue/src/rogue/interfaces/stream/Buffer.cpp:242:16: note: use '==' to turn this assignment into an equality comparison
      if ( tmpPtr = frame_.lock() ) tmpPtr->setSizeDirty();
      ^
      ==
      [ 40%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/Pool.cpp.o
      [ 41%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/Slave.cpp.o
      7 warnings generated.
      [ 42%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/stream/module.cpp.o
      /Users/bareese/rogue/src/rogue/interfaces/stream/Fifo.cpp:94:42: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      log_->info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      1 warning generated.
      [ 44%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/interfaces/module.cpp.o
      [ 45%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/Application.cpp.o
      [ 46%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/Controller.cpp.o
      [ 48%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/ControllerV1.cpp.o
      [ 49%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/ControllerV2.cpp.o
      [ 50%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/Core.cpp.o
      [ 52%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/CoreV2.cpp.o
      [ 53%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/Transport.cpp.o
      [ 54%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/packetizer/module.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/packetizer/Application.cpp:84:40: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      log.info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      [ 56%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/Application.cpp.o
      1 warning generated.
      [ 57%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/Client.cpp.o
      [ 58%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/Controller.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/packetizer/Transport.cpp:74:40: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      log.info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      [ 60%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/Header.cpp.o
      [ 61%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/Server.cpp.o
      1 warning generated.
      [ 62%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/Transport.cpp.o
      [ 64%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/rssi/module.cpp.o
      [ 65%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/srp/Cmd.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/rssi/Application.cpp:79:40: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      log.info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      /Users/bareese/rogue/src/rogue/protocols/rssi/Controller.cpp:352:42: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      log_->info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      1 warning generated.
      [ 66%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/srp/SrpV0.cpp.o
      [ 68%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/srp/SrpV3.cpp.o
      1 warning generated.
      [ 69%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/srp/module.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/rssi/Transport.cpp:73:40: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      log.info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      [ 70%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/udp/Client.cpp.o
      [ 72%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/udp/Core.cpp.o
      [ 73%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/udp/Server.cpp.o
      1 warning generated.
      [ 74%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/module.cpp.o
      [ 76%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/protocols/udp/module.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/srp/SrpV0.cpp:165:27: warning: empty parentheses interpreted as a function declaration [-Wvexing-parse]
      rogue::GilRelease noGil();
      ^~
      /Users/bareese/rogue/src/rogue/protocols/srp/SrpV0.cpp:165:27: note: remove parentheses to declare a variable
      rogue::GilRelease noGil();
      ^~
      /Users/bareese/rogue/src/rogue/protocols/srp/SrpV3.cpp:141:27: warning: empty parentheses interpreted as a function declaration [-Wvexing-parse]
      rogue::GilRelease noGil();
      ^~
      /Users/bareese/rogue/src/rogue/protocols/srp/SrpV3.cpp:141:27: note: remove parentheses to declare a variable
      rogue::GilRelease noGil();
      ^~
      /Users/bareese/rogue/src/rogue/protocols/srp/SrpV3.cpp:175:27: warning: empty parentheses interpreted as a function declaration [-Wvexing-parse]
      rogue::GilRelease noGil();
      ^~
      /Users/bareese/rogue/src/rogue/protocols/srp/SrpV3.cpp:175:27: note: remove parentheses to declare a variable
      rogue::GilRelease noGil();
      ^~
      1 warning generated.
      [ 77%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/fileio/StreamReader.cpp.o
      [ 78%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/fileio/StreamWriter.cpp.o
      [ 80%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/fileio/StreamWriterChannel.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/udp/Client.cpp:156:45: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      udpLog_->info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      2 warnings generated.
      [ 81%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/fileio/module.cpp.o
      /Users/bareese/rogue/src/rogue/protocols/udp/Server.cpp:163:45: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
      [-Wdeprecated-declarations]
      udpLog_->info("PID=%i, TID=%li",getpid(),syscall(SYS_gettid));
      ^
      /usr/include/unistd.h:733:6: note: 'syscall' has been explicitly marked deprecated here
      int syscall(int, ...);
      ^
      1 warning generated.
      [ 82%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/Prbs.cpp.o
      [ 84%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/StreamUnZip.cpp.o
      1 warning generated.
      [ 85%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/StreamZip.cpp.o
      [ 86%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/utilities/module.cpp.o
      [ 88%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/ApiWrapper.cpp.o
      [ 89%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/GeneralError.cpp.o
      [ 90%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/GilRelease.cpp.o
      [ 92%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/Logging.cpp.o
      [ 93%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/SMemControl.cpp.o
      [ 94%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/ScopedGil.cpp.o
      [ 96%] Building CXX object CMakeFiles/rogue-core.dir/src/rogue/Version.cpp.o
      [ 97%] Linking CXX shared library ../lib/librogue-core.dylib
      [ 97%] Built target rogue-core
      [ 98%] Building CXX object CMakeFiles/rogue.dir/src/package.cpp.o
      [100%] Linking CXX shared library ../python/rogue.dylib
      [100%] Built target rogue

              Assignee:
              Ryan Herbst
              Reporter:
              Reese, Benjamin A.
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: